Use is_recording flag in flask, django, tornado, boto, botocore instrumentations #1164
Conversation
| @@ -91,6 +91,8 @@ def collect_request_attributes(scope): | |||
|
|
|||
| def set_status_code(span, status_code): | |||
| """Adds HTTP response attributes to span using the status_code argument.""" | |||
| if not span.is_recording(): | |||
There was a problem hiding this comment.
I wonder if it's worth adding a decorator as a convenience
There was a problem hiding this comment.
Possibly? I think the repetitive-ness of this task just seems obvious because we just didn't do it in the beginning. However, new instrumentations should be respecting this anyways, so I don't think it's that much overhead.
There was a problem hiding this comment.
Was thinking a decorator may help folks building future instrumentations group all the actions that should not occur when a span is not recording more cleanly 🤷♂️
There was a problem hiding this comment.
That would be nice. There are some instrumentations that have some interim steps that always must be regardless of is_recording (which occur between some set_attr... methods). A decorator would be difficult to use in those cases.
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-boto/src/opentelemetry/instrumentation/boto/__init__.py
Show resolved
Hide resolved
I don't believe these needs CHANGELOG entries because they it's not really affecting the user. |
I was thinking the change in behaviour might be unexpected (if anyone was setting is_recording to false and still seeing attributes), though I guess it would have been surprising for this to behave this way in the first place. |
| attributes = collect_request_attributes(environ) | ||
| for attr in self._traced_request_attrs: | ||
| value = getattr(request, attr, None) | ||
| if value is not None: | ||
| attributes[attr] = str(value) |
There was a problem hiding this comment.
@owais created a nifty utils function that you can use like this
| attributes = collect_request_attributes(environ) | |
| for attr in self._traced_request_attrs: | |
| value = getattr(request, attr, None) | |
| if value is not None: | |
| attributes[attr] = str(value) | |
| attributes = collect_request_attributes(environ) | |
| attributes = extract_attributes_from_object( | |
| request, self._traced_request_attrs, attributes | |
| ) |
It's still in PR though so no need to use it if this is ready first.
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
Part of #1057